search

gosu-lang / gradle-gosu-plugin

BSD 3-Clause "New" or "Revised" License
5 stars 7 forks source link

Gosu fails under Gradle 2.12 #21

Closed ysb33r closed 8 years ago

ysb33r commented 8 years ago

The issue is that the Gradle internal API for DefaultSourceDirectorySet has been changed adding a third parameter. (The failure is not unique to Gosu pugin - a number of the community language plugins have also been broken).

One suggested fix is the following - https://github.com/ysb33r/gradle-mirah-plugin/blob/master/src/main/groovy/org/ysb33r/gradle/mirah/MirahSourceSet.groovy#L69

DPUkyle commented 8 years ago

Yes, unfortunately the Gradle APIs change quite often. Of course they are marked internal so we use them at our own peril!

We will certainly address this in the next release , though it would naturally break backwards compatibility with older Gradle versions :( I see your workaround is doing type inspection to see which is the appropriate constructor to call; very nice!

The list of known incompatible versions is also posted on the plugin portal here.

DPUkyle commented 8 years ago

@ysb33r thank you very much for using the plugin, BTW!

ysb33r commented 8 years ago

The link to the code that I posted will maintain compatibility with your current supported Gradle versions.

Sent from my Samsung device

-------- Original message -------- From: Kyle Moore notifications@github.com Date: 31/03/2016 01:24 (GMT+00:00) To: gosu-lang/gradle-gosu-plugin gradle-gosu-plugin@noreply.github.com Cc: "Schalk W. Cronjé" yw-github@af.org.za Subject: Re: [gosu-lang/gradle-gosu-plugin] Gosu fails under Gradle 2.12 (#21)

Yes, unfortunately the Gradle APIs change quite often. Of course they are marked internal so we use them at our own peril!

We will certainly address this in the next release, though it would naturally break backwards compatibility with older Gradle versions :(

The list of known incompatible versions is also posted on the plugin portal here.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub