gosu-lang / gradle-gosu-plugin

BSD 3-Clause "New" or "Revised" License
5 stars 7 forks source link

Remove remaining Gradle internal APIs, if possible #40

Closed DPUkyle closed 6 years ago

DPUkyle commented 6 years ago

As a follow-up to #39, there are a handful of additional places where I have no choice (AFAICT) but to use Gradle internal APIs.

Here are the remaining usages as of v0.3.7 and the justification for them.

org.gosulang.gradle.GosuBasePlugin

Internal APIs used:

Justification:

org.gosulang.gradle.tasks.DefaultGosuSourceSet

Internal APIs used:

Justification:

org.gosulang.gradle.tasks.GosuRuntime

Internal APIs used:

Justification:

--

If there are better ways to do any or all of the above without depending on internal APIs, I would welcome help/advice on how to isolate this plugin from core changes. It's a win-win!

DPUkyle commented 6 years ago

Some references to org.gradle.util still exist and should be removed, but overall the risk footprint of internal API usage is nearly eliminated.