search

goswamiprad / LearningMachine

This repository is developed to get benefitted from hacktoberfest by getting contributors to contribute to make it a useful learning destination for beginners,
2 stars 4 forks source link

Contribute by sharing your knowledge here. #1

Open goswamiprad opened 1 year ago

Om12Dahale commented 1 year ago

@goswamiprad I have added PRs.

goswamiprad commented 1 year ago

Good work. @Om12Dahale I have checked and merged all the PRs. Please leave a star on this repo if you enjoyed it.

goswamiprad commented 1 year ago

@MaryamMahmood001 @Om12Dahale Tell me if you're getting your progress on hacktoberfest website for contributing in this repo. If you're not getting it mentioned then please let me know. Thanks!

Gargi14 commented 1 year ago

@goswamiprad can you please assign me I want to contribute Linear ,Sentinel & Binary Search code in python

goswamiprad commented 1 year ago

@Gargi14 Okay! I'm assigning you this. But contribute fast if you're here for hacktoberfest.

Gargi14 commented 1 year ago

ok Thanks

goswamiprad commented 1 year ago

@Gargi14 Please check your hacktoberfest profile and tell me if you're getting this PR mentioned there? And whether it is accepted or not?

Gargi14 commented 1 year ago

@goswamiprad Pull Requests are not accepted

goswamiprad commented 1 year ago

@Gargi14 Reason?

Gargi14 commented 1 year ago

Need to accept by maintainer, need to merge pr.....

Gargi14 commented 1 year ago

@goswamiprad What is the issue? Will my contributions be reflected?

goswamiprad commented 1 year ago

They should be reflected. I'm a maintainer too.

Gargi14 commented 1 year ago

yes but not reflected ....

goswamiprad commented 1 year ago

This issue is to maintain a repo where beginners can get help for themselves.

Gargi14 commented 1 year ago

yes

goswamiprad commented 1 year ago

Well I would try to look for the reason from my side. If I could find the reason, I shall let you know about it. Don't worry! Thanks for contribution though.

Gargi14 commented 1 year ago

Yes Thanks I learned a lot This was my first time contributing

goswamiprad commented 1 year ago

Well that's the reason why I'm maintaing this repo. This is the first for me too to do any such thing. We're all getting to learn many things here right? Good to know about you @Gargi14

Gargi14 commented 1 year ago

now its showing waiting and a timer

Gargi14 commented 1 year ago

@goswamiprad why a timer is present

goswamiprad commented 1 year ago

Actually I would do that after tonight. I do not want to mess up with your contribution right now. I will move them afterwards.

Gargi14 commented 1 year ago

@goswamiprad It is saying your pr is accepted by maintainer and now is on seven day review period

goswamiprad commented 1 year ago

So that other maintainers can verify it too. As far as I can understand from the timer.

goswamiprad commented 1 year ago

Exactly! that's what I was trying to tell you. As I said, this is my first time doing it too. So I'm just learning about these things.

Gargi14 commented 1 year ago

@goswamiprad It also says it will be counted in hacktoberfest So when will it reflect after 7 days that 4/4?

goswamiprad commented 1 year ago

@Gargi14 Yeah hopefully it does. Let's wait and be optimistic.

Gargi14 commented 1 year ago

Well that's the reason why I'm maintaing this repo. This is the first for me too to do any such thing. We're all getting to learn many things here right? Good to know about you @Gargi14

Thanks for your guidance. Next time I will start early