gotcha / ipdb

Integration of IPython pdb
BSD 3-Clause "New" or "Revised" License
1.85k stars 146 forks source link

Revert "Add use_2to3 keyword to setup()." #173

Closed blueyed closed 4 years ago

blueyed commented 4 years ago

Appears to not be necessary anymore (at least no changes for py37 for me), and prevents editable installs.

Initially done for https://github.com/gotcha/ipdb/pull/16.

This reverts commit d86c166b61aa711e6b0197c3d914031c0651ca15.

codecov-io commented 4 years ago

Codecov Report

Merging #173 into master will increase coverage by 0.76%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   38.85%   39.62%   +0.76%     
==========================================
  Files           5        5              
  Lines         157      159       +2     
==========================================
+ Hits           61       63       +2     
  Misses         96       96
Impacted Files Coverage Δ
setup.py 100% <ø> (ø) :arrow_up:
ipdb/__main__.py 26.36% <0%> (+0.67%) :arrow_up:
ipdb/stdout.py 44.44% <0%> (+2.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 114d1f9...86a8ade. Read the comment docs.

gotcha commented 4 years ago

@blueyed Do you need a release ?

blueyed commented 4 years ago

@gotcha No, thanks for asking.. :)

btw: I was looking at it since I will likely drop the dependency on fancycompleter/pyrepl from pdb++ (make it optional), since it works pretty good through ipdb/ipython, which has better completion via Jedi then.

You might want to try it (use master, the last release is old - https://github.com/pdbpp/pdbpp/): when using ipdb.set_trace the hijacking of pdb++ makes it being used there then also.

gotcha commented 4 years ago

@blueyed Thanks for the pointer ! I did not know there was a way to override pdb. The fact I need to be explicit about ipdb is the main reason why I dont use it as regularly as I wish.