alexandrebarbaruiva commented 4 years ago

Add option to retrieve context from environment variable IPDB_CONTEXT_SIZE or from setup.cfg file.

codecov-io commented 4 years ago

Codecov Report

Merging #187 into master will increase coverage by 27.9%. The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   40.37%   68.27%   +27.9%     
==========================================
  Files           5        6       +1     
  Lines         161      331     +170     
==========================================
+ Hits           65      226     +161     
- Misses         96      105       +9

Impacted Files	Coverage Δ
ipdb/__main__.py	`47.5% <94.11%> (+21.13%)`	:arrow_up:
tests/test_config.py	`95% <95%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d379edd...0428cd4. Read the comment docs.

gotcha commented 4 years ago

Thanks for nice PR ! Would you mind adding some documentation and update the changelog ?

alexandrebarbaruiva commented 4 years ago

I'll add tests, documentation and update the changelog after the 12th of this month (I'm having tests at my uni :cry: but I'll do it ASAP)!

gotcha commented 4 years ago

@alexandrebarbaruiva Take care of your uni tests first ! Good luck

alexandrebarbaruiva commented 4 years ago

@gotcha added tests, documentation and updated changelog! (and I passed my tests :smile:)

gotcha commented 4 years ago

@alexandrebarbaruiva Thanks for your work !

And great for your tests !

FYI, the way you changed HISTORY was breaking the release process with zest.releaser (Very convenient tool if you release often to PyPI). See 8fe1d167cf3f5 where I fixed it.

gotcha commented 4 years ago

Released as https://pypi.org/project/ipdb/0.13.1/

gotcha / ipdb

Add option to use context from env var or config file #187

Codecov Report