gotcha / ipdb

Integration of IPython pdb

BSD 3-Clause "New" or "Revised" License

1.85k stars 146 forks source link

Add -m option #193

Closed MrMino closed 4 years ago

MrMino commented 4 years ago

This adds a -m option that was introduced in Python 3.7 pdb. It is implemented in a backward-compatible way: if the version of python is lower than 3.7, the script will fallback to shortopts without -m.

See #192.

Added -m option
Added test/test_opts.py for coverage
Added mock to tests_require in setup.py, so that tests work with Python 2.7.

codecov-io commented 4 years ago

Codecov Report

Merging #193 into master will decrease coverage by 1.52%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
- Coverage   67.15%   65.62%   -1.53%     
==========================================
  Files           6        6              
  Lines         344      352       +8     
==========================================
  Hits          231      231              
- Misses        113      121       +8

Impacted Files	Coverage Δ
ipdb/__main__.py	`44.75% <0.00%> (-2.07%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 251adcc...eab5b3f. Read the comment docs.

codecov-commenter commented 4 years ago

Codecov Report

Merging #193 into master will increase coverage by 11.42%. The diff coverage is 96.00%.

@@             Coverage Diff             @@
##           master     #193       +/-   ##
===========================================
+ Coverage   67.15%   78.57%   +11.42%     
===========================================
  Files           6        7        +1     
  Lines         344      392       +48     
===========================================
+ Hits          231      308       +77     
+ Misses        113       84       -29

Impacted Files	Coverage Δ
setup.py	`100.00% <ø> (ø)`
tests/test_opts.py	`94.73% <94.73%> (ø)`
ipdb/__main__.py	`66.66% <100.00%> (+19.84%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 251adcc...708a2fc. Read the comment docs.

MrMino commented 4 years ago

@gotcha is there anything I should add here?

gotcha commented 4 years ago

@MrMino No, it is fine as it is. Sorry to have missed it. Do not hesitate to ping me quicker next time.

gotcha commented 4 years ago

Released in https://pypi.org/project/ipdb/0.13.4/

MrMino commented 4 years ago

Thanks! :)