search

gotcha / ipdb

Integration of IPython pdb
BSD 3-Clause "New" or "Revised" License
1.85k stars 146 forks source link

Drop Python 2.7 support #243

Open adamchainz opened 2 years ago

adamchainz commented 2 years ago

Upstream IPython dropped it in version 6.0.0, in April 2017. I think it's fine to drop it here now.

Would also be good to use this opportunity to mark the release as 1.0.0.

gotcha commented 2 years ago

I would like to keep 2.7 support unless it avoids support for new features...

adamchainz commented 2 years ago

Why? It's dead for nearly 2 years now. For those on Python 2, pip will install the old version, thanks to python_requires.

gotcha commented 2 years ago

As said above, if it does not hinder new features, I see no reason to stop support.

Further, I know a lot of people still using Py 2.

adamchainz commented 2 years ago

Okay well up to you. You can keep this PR open for when the time comes if you like.

gotcha commented 2 years ago

Good point

malkstar commented 2 years ago

2.7 IPython vulernability fixes won't be installable through pip for https://github.com/gotcha/ipdb/pull/248, as they're installable from source only.

ssbarnea commented 2 years ago

@gotcha merge it please! Let's avoid disturbing the dead, or better avoid being hunted by zombies.