gotenberg / gotenberg

A developer-friendly API for converting numerous document formats into PDF files, and more!
https://gotenberg.dev
MIT License
7.23k stars 471 forks source link

#840: added more extensions according to online docs @ libreoffice #841

Closed roy20021 closed 3 months ago

roy20021 commented 3 months ago

I have manually reported source code extension list and libreoffice documentation https://books.libreoffice.org/en/GS74/GS7410-FileFormatsSecurityExporting.html into 2 files (sorted, removed duplicates, everything to lowercase): source_code.txt from_docs.txt

Accordingly, I have updated the source code and tested with ".dxf" file successfully.

gulien commented 3 months ago

Amazing, thanks! 🚀

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.70%. Comparing base (eb05414) to head (8c3286f). Report is 1 commits behind head on main.

:exclamation: Current head 8c3286f differs from pull request most recent head 5af6e77. Consider uploading reports for the commit 5af6e77 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #841 +/- ## ========================================== + Coverage 91.59% 91.70% +0.11% ========================================== Files 44 44 Lines 3628 3677 +49 ========================================== + Hits 3323 3372 +49 Misses 219 219 Partials 86 86 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gulien commented 3 months ago

Could you rebase with main? The tests are failing but the CI was still in success. This behavior has been fixed on main.

gulien commented 3 months ago

Thanks @roy20021!

gulien commented 3 months ago

gotenberg/gotenberg:edge should be available in ~1 hour with your update.