search

gotenberg / gotenberg

A developer-friendly API for converting numerous document formats into PDF files, and more!
https://gotenberg.dev
MIT License
7.23k stars 471 forks source link

feat(chromium): add user agent override #901

Closed gulien closed 2 weeks ago

gulien commented 2 weeks ago

Closes #900.

New form field userAgent.

gulien commented 2 weeks ago

@wjkoh I have tested it successfully!

The image gotenberg/gotenberg:edge should be updated within ~1 hour. I plan to release a new version once https://github.com/gotenberg/gotenberg/pull/898 is merged, but the edge tag is pretty stable.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.97%. Comparing base (ed67d85) to head (df28dc0).

Files Patch % Lines
pkg/modules/chromium/tasks.go 90.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #901 +/- ## ========================================== + Coverage 91.91% 91.97% +0.05% ========================================== Files 46 46 Lines 4021 4036 +15 ========================================== + Hits 3696 3712 +16 Misses 230 230 + Partials 95 94 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wjkoh commented 2 weeks ago

Wow, it works like magic! Thanks @gulien for such a quick fix! This update allows us to remove a lot of unnecessary code from our app. 😆 Once again, thank you so much, Julien!