search

gotestyourself / gotestsum

'go test' runner with output optimized for humans, JUnit XML for CI integration, and a summary of the test results.
Apache License 2.0
2.03k stars 119 forks source link

dotsv2: remove jitters entirely #368

Closed howardjohn closed 11 months ago

howardjohn commented 12 months ago

As best I can tell, this fully fixes https://github.com/gotestyourself/gotestsum/issues/352

While there were a variety of workarounds I tried to fix this, which had some improvement, the real root cause is doing clear screen; write. This leaves some time where each cell in the terminal goes from <something> -> empty -> <something>, which leads to blinking.

Instead, we can write and clear as we go. This has the same end result, but avoids the intermediate step where we have an empty cell.

This PR is probably not acceptable as-is as it doesn't even compile on windows. Not sure the best steps there, I neither have experience with implementing this in windows nor a machine to test on. We could keep the old implementation for windows, possibly.

dnephin commented 12 months ago

Nice! This works great for me. I also don't have a windows machine. I think leaving the old implementation for windows would be fine.

howardjohn commented 11 months ago

Nice! This works great for me. I also don't have a windows machine. I think leaving the old implementation for windows would be fine.

SGTM, I left it as-is for now and commented that it could be improved in the future if someone wants