search

gothinkster / angular-realworld-example-app

Exemplary real world application built with Angular
https://angular.realworld.how/
MIT License
5.25k stars 3.16k forks source link

Feature request: add unit tests #3

Open ogix opened 8 years ago

ogix commented 8 years ago

It would be nice to add unit tests for this app.

EricSimons commented 8 years ago

Totally -- PR's would be very appreciated for this as I'm swamped for the next month or so. Anyone out there wanna contribute some sweet unit tests? :)

EricSimons commented 8 years ago

@ogix @npx any chance ya'll (or anyone else reading this) would be interested?

ogix commented 8 years ago

Ok, I could try but I guess it will take some time because I don't have much experience writing Angular2 unit tests. I will follow the official guide.

EricSimons commented 8 years ago

Okay -- we might have to do 1-2 rounds of revisions FYI, just to ensure everything is solid & the ang team approves. Can you drop me a note at eric@thinkster.io and we'll hammer out details?

ogix commented 8 years ago

I have sent you an email.

pauldubois777 commented 8 years ago

I'd be happy to write some tests. Where should I start?

EricSimons commented 8 years ago

@pauldubois777 awesome! we're currently chatting about this in our private slack channel; can you send me an email at eric@thinkster.io and I'll invite you?

pauldubois777 commented 8 years ago

Email sent. Thanks!

babilog commented 7 years ago

This thread sort of when cold, any progress on the unit tests? Please let me know if anyone needs more help on this task.

EricSimons commented 7 years ago

@babilog yeah, this ended up not happening the first time around unf. If you make a PR for unit tests I will absolutely accept them 👍

umondelo commented 7 years ago

any progress on the unit test?

babilog commented 7 years ago

Hi @umondelo , unfortunately I'm still working on these at the moment. I can probably push a branch later this weekend.

babilog commented 7 years ago

@EricSimons , I'm trying to push my local branch to the repo but currently receiving a permissions issue. Running git push origin mybranchname ... Any thoughts?

babilog commented 7 years ago

$ git push -u origin feature-unit-tests remote: Permission to gothinkster/angular-realworld-example-app.git denied to babilog. fatal: unable to access 'https://github.com/gothinkster/angular-realworld-example-app.git/': The requested URL returned error: 403

sandeesh commented 7 years ago

@babilog only those added to the collaborators can make changes directly to this repo. You need to create a PR to get the changes pushed here after someone verifies them. To do so upload the repo to your account and create a PR with your new repo to this one.

EricSimons commented 7 years ago

@babilog ^ what @SandeeshS said! Feel free to make a pull request & I'll review + accept 👍

nicojs commented 6 years ago

@babilog do you have the tests? I would be grateful for them 🥇

iameduardod commented 4 years ago

any update on unit tests?!

wojo1206 commented 3 days ago

Without unit tests, this project isn't world class project. This project promotes really bad practice and doesn't inform users about that. In modern programming, absence of unit testing disqualifies a project from production workloads. This isn't good project.