search

gothinkster / aspnetcore-realworld-example-app

ASP.NET Core backend implementation for RealWorld
https://realworld.io
MIT License
1.94k stars 549 forks source link

Database provider SQlLite hard-coded #56

Closed dsergiu77 closed 5 years ago

dsergiu77 commented 5 years ago

Hi,

it would be nice if the database provider / connection string is read from a configuration file and not hard-code to SqlLite (in Startup and ConduitContext).) I can imagine that someone would like to use an InMemoryDatabase for testing.

Greetings, Sergiu

adamhathcock commented 5 years ago

Using a configuration file like old ASP.NET xml config isn't 12 factor app style.

If you want to change the code to use environment variables to gather that info, then I'd accept the PR :)

dsergiu77 commented 5 years ago

Cool idea, I will try this and submit a PR.

adamhathcock commented 5 years ago

Fixed