gothinkster / aspnetcore-realworld-example-app

ASP.NET Core backend implementation for RealWorld
https://realworld.io
MIT License
1.94k stars 549 forks source link

Default connection string is hard-coded, only SQLite can be used. #68

Closed benedict-chan closed 5 years ago

benedict-chan commented 5 years ago

If not setting the environment variables, the default connection is hard-coded to SQLite as it prefixed with a "Filename="

var connectionString = _config.GetValue<string>("ASPNETCORE_Conduit_ConnectionString") ?? $"Filename={DEFAULT_DATABASE_FILE}";

Also to make it consistent, the default variable should be named "connection string" like the environment variable.

adamhathcock commented 5 years ago

Thanks!