search

gothinkster / aspnetcore-realworld-example-app

ASP.NET Core backend implementation for RealWorld
https://realworld.io
MIT License
1.94k stars 549 forks source link

Code cleanup. #71

Closed 1fisedi closed 5 years ago

adamhathcock commented 5 years ago

Why do this? What tool did you run this through?

1fisedi commented 5 years ago

@adamhathcock , to improve code readability and follow some common conventions, from vs tools and to continue to work on suggested issues, later on.

adamhathcock commented 5 years ago

What conventions? What tooling specifically? There are a lot.

I'm not against formatting changes but it needs to be more considered. I'd rather have real functional changes from PRs then we can discuss standards where needed.

1fisedi commented 5 years ago

Simply using integrated standard Visual Studio code cleanup tools, and framework design guidelines. Next, I was planning on using Codacy to improve code quality, Though, if the functionality is the only priority, I could try focusing on that.

adamhathcock commented 5 years ago

Sorry. I don't believe running the code through automated tools without thought and some agreement on what's applicable is useful.

Functionality and examples of structure is the purpose of this project. A .NET Core 3 update would be an example of a useful update.