search

gothinkster / aspnetcore-realworld-example-app

ASP.NET Core backend implementation for RealWorld
https://realworld.io
MIT License
1.94k stars 549 forks source link

[wip] fix deploy action #83

Closed mrparkers closed 4 years ago

mrparkers commented 4 years ago

Sorry! I did not mean to open this PR against this repo.

adamhathcock commented 4 years ago

No problem but it makes me think if I have reference cycle issues 🤔

mrparkers commented 4 years ago

I installed the NewtonsoftJson package because of some JSON cycling issues when attempting to use this backend with the react-redux front-end. I'm no expert on .net core though so there may be better ways to fix this.

If you want, I can open a PR with that first commit you see in the changelog.

adamhathcock commented 4 years ago

It’s a common problem with the new System.Text.Json that should be fixed with .NET 5.

Happy to accept a PR but just didn’t think the model was complex enough for it.