aurelia should replace moment.js with date-fns, saves 10-15kb gzipped. (make it faster)

gothinkster / aurelia-realworld-example-app

Exemplary real world application built with Aurelia

https://realworld.io

MIT License

184 stars 32 forks source link

aurelia should replace moment.js with date-fns, saves 10-15kb gzipped. (make it faster) #12

Closed loaded02 closed 6 years ago

loaded02 commented 6 years ago

date-fns is not working with cli setup issue. Any ideas?

loaded02 commented 6 years ago

aurelia cli and webpack should do it...

loaded02 commented 6 years ago

I am trying to switch the project to a 'aurelia cli with webpack' - setup. Any ideas what I am missing? Somehow the router config isnt called. Experimental branch

loaded02 commented 6 years ago

Ok I made it work! Date-fns is working with a aurelia-cli setup with webpack as a module loader. Size comparisson of the bundles is:

require-js and momentjs 480Kb
webpack and date-fns 460 Kb at this branch @vegarringdal what do you think? Is it worth it? There might be optimization potential especially regarding excluding sourcemaps. I am no webpack expert and couldnt get rid of the sourcemaps just now. Might try later.

vegarringdal commented 6 years ago

yes, think 20kb is good :-) is it minified, how much gzipped?

loaded02 commented 6 years ago

Cool thanks!! Any optimization hints for this pr #33? Could not exclude sourcemaps from beeing generated, but I excluded them from beeing deployed by travis. Files are minified. Cant see gzipped status though.