search

gothinkster / aurelia-realworld-example-app

Exemplary real world application built with Aurelia
https://realworld.io
MIT License
183 stars 32 forks source link

bluebird, remove it to speed up ? #30

Closed vegarringdal closed 6 years ago

vegarringdal commented 6 years ago

bluebird, remove it to speed up ? https://github.com/gothinkster/aurelia-realworld-example-app/blob/master/package.json#L18

any reason to keep this ?

loaded02 commented 6 years ago

@vegarringdal We could get rid of it in favor of bundle size, but bluebird is actually a faster Promise library than the default one. As far as I understood it.

vegarringdal commented 6 years ago

@loaded02 That was only in Edge wasn't it? (maybe I remember wrong) No one running chrome lighthouse from Edge browser and posting on blogs :-)

loaded02 commented 6 years ago

@vegarringdal you are right about edge. We should drop it. We are not targeting edge ;)

vegarringdal commented 6 years ago

👍

Great, Im thinking a simple note what needs to be added for support for IE11 is good enough (polyfill for promise and fetch)