Closed jk7g14 closed 7 years ago
Hello,
Sorry for the delay, I didn't notice the github Email just for the new change, there is really no proper way to do this, your solution is fine.
Maybe you should add a test so that this won't happen again and I will merge it.
hmm...
I tried to add a comment view test, but I can't see or access marshmallow results during the test.
Merged thanks.
Nice! I'm learning from you a lot. Thank you!
With elm front-end, if there is a comment, there is an error while loading an article.
According to realworld api https://github.com/gothinkster/realworld/tree/master/api#single-comment,
this is the right example.
but in flask-realworld, we got this.
The only difference between these is 'author' section. We need to remove profile key and put profile's item to 'author' section.
because I don't know how schema? works here, I just removed profile key like below...
I think this is just a fast easy solution for this since I don't know how schema class works.
I knew this part has a problem. I don't know how to fix it lol.