gothinkster / golang-gin-realworld-example-app

Exemplary real world application built with Golang + Gin
https://realworld.io
MIT License
2.52k stars 496 forks source link

update package name and upgrade gin #10

Open thinkerou opened 6 years ago

wangzitian0 commented 6 years ago

Thank you very much! It's a very nice PR, I have left some comments. BTW, I don't know weather travis CI works fine, you could have a try on your own project firstly, that will reduce environment and version changing risk. It will help us test different environment and auto running the tests. https://github.com/gothinkster/golang-gin-realworld-example-app/blob/master/.travis.yml

thinkerou commented 6 years ago

@wangzitian0 thanks review, I will retry the weekend.

shrhawk-entertainer commented 5 years ago

why this is not merged ?

xdays commented 5 years ago

why not merged?

y4code commented 5 years ago

@wangzitian0 who got the write access to this repo? please notify him/her to merge this PR, thanks.