search

gothinkster / golang-gin-realworld-example-app

Exemplary real world application built with Golang + Gin
https://realworld.io
MIT License
2.5k stars 495 forks source link

Made compatible with Go modules #23

Closed pvillela closed 3 years ago

pvillela commented 3 years ago

Added go.mod, removed vendors and dependence on github.com/wangzitian0/golang-gin-starter-kit. All unit tests pass.

pvillela commented 3 years ago

My pleasure. Thank you for writing the nice example code.

Regards, Paulo

On Tue, Mar 30, 2021 at 1:24 PM wangzitian0 @.***> wrote:

@.**** approved this pull request.

LGTM! Thanks for the nice change!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gothinkster/golang-gin-realworld-example-app/pull/23#pullrequestreview-624522714, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD4LPKNM577GOGYX4WLT7LTGICNZANCNFSM42BZUR3A .

wangzitian0 commented 3 years ago

@pvillela Do you have time to take a look at the badges at the readme including coverage and CI? Seems it failed after this PR..

pvillela commented 3 years ago

I clicked on the badges but I don't have access. Besides, I'm not familiar with travis. Nonetheless, I suspect the problem is due to changes in some of the dependencies. I went back to your previous commit on master, regenerated go.mod, and synced it with vendor.json (go mod vendor). After that, I again removed the dependence on the starter-kit repo. Again, all unit tests passed. I have pushed a new PR with this.

On Wed, Mar 31, 2021 at 1:34 AM wangzitian0 @.***> wrote:

@pvillela https://github.com/pvillela Do you have time to take a look at the badges at the readme including coverage and CI? Seems it failed after this PR..

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gothinkster/golang-gin-realworld-example-app/pull/23#issuecomment-810776423, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD4LPK6HHJ6DIPCUSQPEITTGKX4RANCNFSM42BZUR3A .