search

gothinkster / golang-gin-realworld-example-app

Exemplary real world application built with Golang + Gin
https://realworld.io
MIT License
2.52k stars 497 forks source link

question: about package name #8

Closed thinkerou closed 3 years ago

thinkerou commented 6 years ago

Hi, @wangzitian0 @EricSimons I found the repo come from your personal repo https://github.com/wangzitian0/golang-gin-starter-kit, so, if your personal repo no longer maintain please mark as warning and redirect here. Because I want to learn/use and commit pull request, but I don't know commit where, thanks!

BTW, if you permit, we should link the repo to gin readme.

wangzitian commented 6 years ago

Hi, @thinkerou , The codes of two repo are same now, doc has a little different. In general, gothinkster's repo is enough, but the management of golang package in this project was not very well yet, even some package path in gothinkster's repo was using my personal repo full path... I think before the warning, we should:

  1. Modify & check the import path in gothinkster's repo, better using relative path.
  2. Make sure the two repo has no rely relationship..
  3. Duplicate my personal repo.

Welcome to do the step1 &step2, thanks, hhhh

wangzitian0 commented 6 years ago

@EricSimons Hi, Eric, Could you please help adding the travis CI app to https://github.com/gothinkster/golang-gin-realworld-example-app or add me to the gothinkster organization temporarily? I used to using my personal project to do that, for long term consideration, https://github.com/gothinkster/golang-gin-realworld-example-app/pull/10 was duplicating the rely relationship.. Thank you!

wangzitian0 commented 6 years ago

@EricSimons Friendly ping.

wangzitian0 commented 6 years ago

In general, the operation should be: In https://github.com/marketplace/category/continuous-integration add Codecov and Travis CI. In https://github.com/marketplace/travis-ci, click Configure access. Then, click the configure of Codecov and Travis CI, give them permission.

Or add me to the gothinkster organization temporarily? Thank you very much, Eric! @EricSimons