gothinkster / react-mobx-realworld-example-app

Exemplary real world application built with React + MobX
https://react-mobx.realworld.io/
MIT License
1.25k stars 266 forks source link

Safety for password #21

Closed popo63301 closed 6 years ago

popo63301 commented 7 years ago

Is it safe to put the password in the observable in the AuthStore? Is it a good practice? If not, what should we do?

andykog commented 6 years ago

@popo63301, if you are not paranoid enough to use randomized virtual keyboards and all that stuff, then I wouldnt worry about MobX. Having access to javascript context allows one to retrieve password from a dom input anyway.