Closed deksden closed 7 years ago
I think a better solution would be to leave it at 3000 with the changes you've made and document the ability to change port by editing the script before starting. A change in readme regarding this is needed, currently it says the port used is 3000. A note for users to change the port to avoid conflicts while running the backend would be a plus.
@SandeeshS : nope. You also trapped in this port mash.
Readme mentioned uri/port for local node/rails backend - its fine to leave it as is - 3000 port for api. No need in readme change.
But current frontend's webserver port was also 3000 - now with my PR its changed to 4100.
What i meant to say was to make use of cross-env to let users change the port. My suggestion was to use it and set the port to the way it is and give a note to users to have them change when needed during testing. At the same time it wouldn't be practical for users who just wanna get the frontend and backend up with least effort.
You should at least include the port change in the readme in the PR.
Ok, i m agree, no problem - i will add commit with some readme stuff!
@SandeeshS : I will ask to check my English for readme text - i m not sure if it will be ok
@deksden sure :+1:
@SandeeshS : PR updated with readme docs
@deksden didn't expect you to go so detailed haha :+1:
@SandeeshS : maybe details can be moved to separate wiki page
I think it's good to have this info in the readme actually, as I'm sure it will be a common question people run into 👍
Thanks a ton!! 💯
We should change default port from 3000 to 4100 to prevent conflict with locally running node/rails backend for Conduit (they also have default port 3000).
This fixes https://github.com/gothinkster/react-redux-realworld-example-app/issues/52