gothinkster / realworld

"The mother of all demo apps" โ€” Exemplary fullstack Medium.com clone powered by React, Angular, Node, Django, and many more
https://realworld-docs.netlify.app/
MIT License
80.58k stars 7.34k forks source link

Dojo 2 #167

Closed agubler closed 6 years ago

agubler commented 6 years ago

A Dojo 2 implementation of Conduit RealWorld application

The project repository can be is here

Please let me know if there is anything more that needs doing! Thanks!

agubler commented 6 years ago

Hey all, is there anything I need to do help get this implementation through?

Cameron-C-Chapman commented 6 years ago

This looks awesome @agubler ๐Ÿ˜„

Hi @agubler, typically we like to get some review from some members of the frameworks community. Do you know anyone who has some experience with Dojo who can give a thumbs up? If not we'll just need to verify everything works and we'll get it added to the home page.

Let us know if you have anyone who can review or if you're ready for us to just go ahead and verify functionality.

agubler commented 6 years ago

Hey @cameron-c-chapman, Iโ€™m a contributor on Dojo 2 so I think you can go ahead and review the functionality if thatโ€™s okay?

Let me know if you find anything thatโ€™s not quite right and Iโ€™ll fix it up ๐Ÿ˜ƒ

quanla commented 6 years ago

Hi @agubler, I just tried login using your demo and when server return error, my email/password inputs are cleared so I need to retype. Can I have those values stay in the input so I can change and submit again easier? Does Dojo 2 support that?

agubler commented 6 years ago

@quanla could potentially not clear the email input, but it seems common practice to clear at least the password input after a failed login attempt. Itโ€™s not any limitation of Dojo 2 but simply by my initial design ๐Ÿ˜ƒ

Cameron-C-Chapman commented 6 years ago

@agubler I'm starting to look at it as well and I had to install the dojo cli but I didn't see that in the README. That would be a good note to add.

quanla commented 6 years ago

Ok. Great to know. Thanks @agubler. Btw, is Dojo 2 a reactive programing framework?

agubler commented 6 years ago

@cameron-c-chapman Ah yup you need the cli, iโ€™ll add that to the readme. Thanks!

agubler commented 6 years ago

@quanla yes Dojo 2 is a reactive framework written in Typescript.

Cameron-C-Chapman commented 6 years ago

@agubler this looks good to me. Awesome work! Dojo 2 looks pretty cool, I might have to play around with it a little bit ๐Ÿ˜„

@EricSimons Are you good with getting this added officially?

agubler commented 6 years ago

@Cameron-C-Chapman Thanks! I added the @dojo/cli as a development dependency, added a few npm scripts and updated the readme instructions so it should just work out of the box now.

agubler commented 6 years ago

@EricSimons @Cameron-C-Chapman is there anything more I need to do to get this officially added? Thanks!

EricSimons commented 6 years ago

@agubler so sorry about my delay here! I'll get this listed on the main readme first thing tmrw morn ๐Ÿ‘ awesome work on this!!

agubler commented 6 years ago

@EricSimons Thank you!!

EricSimons commented 6 years ago

This is now listed on the main readme! Amazing work @agubler!! ๐ŸŽ‰

agubler commented 6 years ago

Awesome thanks @EricSimons

agubler commented 6 years ago

@EricSimons Do you mind if I update the realworld repo for Dojo2 directly? Is there a ghpages that it deploys to or do I need to keep that pointing to my ghpage deployment?