gothinkster / realworld

"The mother of all demo apps" — Exemplary fullstack Medium.com clone powered by React, Angular, Node, Django, and many more
https://www.realworld.how/
MIT License
80.37k stars 7.31k forks source link

🗄🔧 Laravel #20

Closed unicodeveloper closed 7 years ago

unicodeveloper commented 7 years ago

Current Status

Todo:


I would love to work on this!

lincolnbrito commented 7 years ago

+1 me too!

EricSimons commented 7 years ago

@unicodeveloper @lincolnbrito Awesome — lets get this started! Can one of you fork our starter kit and post the link in this issue? I also created a logo that you can use for the readme:

laravel-realworld-logo

EricSimons commented 7 years ago

Just set up the Gitter chatroom for this! Lets do our collaborator coordination in there 👍

cc/ @unicodeveloper @lincolnbrito

Hasnayeen commented 7 years ago

@EricSimons I've setup a repo for this https://github.com/iluminar/laravel-realworld-example-app

Hasnayeen commented 7 years ago

Task list categorized by api

Hasnayeen commented 7 years ago

I'm working on Register and Login api

MattMangoni commented 7 years ago

If nobody's already working on it, I'll take care of the articles API

sandeesh commented 7 years ago

So I took the liberty to finish this myself from scratch, since I had some time on my hand and wanted to start making contributions to the open source community :)

I've updated and cleaned up the repo. The latest code can be found below. I've added clear documentation throughout the code. The only thing pending is updating the read me with instructions and info related to code. https://github.com/SandeeshS/laravel-realworld-example-app

I want to know if we can create a new PR for the laravel backend and point to this. Since contributors can easily find and work on this repo, or we clean up this PR and continue here. I'll wait for reviews from fellow members before finalising the code changes and then tag v1. Appreciate any feedback.

EricSimons commented 7 years ago

@SandeeshS holy smokes! Nice work!!!

@Hasnayeen @unicodeveloper @MattMangoni can you guys take a look at the repo @SandeeshS made and lmk if I can update the status to point at that?

Hasnayeen commented 7 years ago

@EricSimons , yes, I think that would be a good idea

sandeesh commented 7 years ago

Well looks like the laravel section is really lacking contributors.

I've added complete model factories and a full configurable database seeder. So anyone can just run the seeder and have a ready server populated with data, including all the relationships. This will be very useful for users testing the api or trying to couple the frontend.

The readme is updated with the complete instructions and information regarding the app. I'm gonna couple a frontend on my local server and perform few final tests and then tag v1 for use.

@EricSimons can you please change the main comment to reflect the repo changes and the task list. Also all the task list mentioned in https://github.com/gothinkster/realworld/issues/20#issuecomment-296448431 are complete.

EricSimons commented 7 years ago

@SandeeshS just cloned your repo and put it under the main org + added you to it!

Lets get the RFC opened up on this thing — does anyone know folks on the core Laravel team/community that could come provide feedback?

unicodeveloper commented 7 years ago

@EricSimons I have taken my time to go through the source code and I can comfortably say that this is SOLID! @SandeeshS did a great job!!!

Thanks for owning this man! 🍾 👍

sandeesh commented 7 years ago

@unicodeveloper thank you. The code base has been updated with cors and some more changes and should be set. We'll wait for a review like @EricSimons says before tagging a main release. Meanwhile i'll be taking any issues or PR and keep things in check. Next on the list is adding tests. If someone wants to then they can go forward and do it, if not i'll work on it once i get some time on my hand.

sandeesh commented 7 years ago

@EricSimons anyway we can push the completed backend on the main page? I'd consider @unicodeveloper as a good peer for the review judging by his background in the laravel community. You guys could do a test run with a local setup to verify the api, there's clear instructions.

I also started writing tests, so that it'd be easier for anyone to make changes going further.

EricSimons commented 7 years ago

@SandeeshS absolutely — I just need to change the layout/design of the readme to be able to accommodate this + upcoming stacks :) Will have this listed there by EOD. Great job! 💯

jamesbrewerdev commented 7 years ago

Since this has been moved to the GoThinkster org, I vote that we close this issue. All future conversation should happen in gothinkster/laravel-realworld-example-app unless it's application to the RealWorld project at large.

cc @EricSimons

EricSimons commented 7 years ago

Agreed — closing this issue 👍