search

gothinkster / realworld

"The mother of all demo apps" — Exemplary fullstack Medium.com clone powered by React, Angular, Node, Django, and many more
https://realworld-docs.netlify.app/
MIT License
80.65k stars 7.34k forks source link

Imba #314

Closed cartonalexandre closed 5 years ago

cartonalexandre commented 5 years ago

I am going to start building the Realworld application using Imba.

Imba treats DOM elements as a first-class citizens. These elements are compiled to an inline dom, which is anorder of magnitude fasterthan todays virtual dom implementations.

The project repository : imba-realworld-example-app

Work in progress

Feel free to help me 😃

cartonalexandre commented 5 years ago

@anishkny Hi Anish, I just finish implementation. I don't know how can I host it to have an online demo

anishkny commented 5 years ago

Looks great. Couple of notes:

  1. I noticed that the profile pic in top navbar is too big when logged in. Could you fix that?
  2. Also, you can probably exclude dist folder from the repo as a best practice (just add it to .gitignore file).

For a demo, you have a few options:

  1. Netlify
  2. GitHub Pages

We can discuss over at your repo...

Great work! 🎉🎉🎉

cartonalexandre commented 5 years ago

Thanks for your feedback, issue is fixed. I think I can't ignore dist because dist/index.html isn't generated from another folder. I added demo link on readme

anishkny commented 5 years ago

Thanks for adding! Please send a PR adding your project to etc/frontend-repos.yaml

One more thing that is very useful to people who want to learn is adding a CI build for your repo - it also ensures high quality going forward. Would you be able to setup say TravisCI for building your project?