search

gothinkster / realworld

"The mother of all demo apps" — Exemplary fullstack Medium.com clone powered by React, Angular, Node, Django, and many more
https://realworld-docs.netlify.app/
MIT License
80.65k stars 7.34k forks source link

Use of hashtag fragments in routes #536

Open skerit opened 4 years ago

skerit commented 4 years ago

Hi,

I want to create a fullstack implementation of Realworld for an MVC we use at our company, but I noticed the spec seems to dictate the use of hashtag routes (/#/) instead of fully qualified pathnames. I've never been a fan of those, are they really required for fullstack implementations?

Qclanton commented 4 years ago

I noticed that not all of implemented Frontends followed that rule. For example, AngularJS implementation (https://angular.realworld.io/) does not contain hashtags in routes. So, my guess, it is not required.

cirosantilli commented 3 years ago

We should not only remove /#/ from the spec, but also have frontend test that check that they are not present: https://github.com/gothinkster/realworld/issues/269 We should encourage the URLs of all implementations to look exactly the same.

plusgut commented 3 years ago

@cirosantilli I slightly disagree, from my understanding the purpose of the realworld-project is to show of the best practices of each framework. I would argue that url-handling is an implementation detail, where each framework has different approaches of what is best.

Enforcing a specific kind of url would limit the way a framework can express itself, without any actual gain in comparability.

geromegrignon commented 3 years ago

@plusgut, as we are working on a set of e2e testing, having different usages will have an impact.

Would you have in mind some examples of frameworks using the hashtag as part of their best practices?