gothinkster / spring-boot-realworld-example-app

Example Spring codebase containing real world examples (CRUD, auth, advanced patterns, etc) that adheres to the RealWorld API spec.
MIT License
1.31k stars 680 forks source link

Extra collection of tags into Set #31

Closed vimahk closed 3 years ago

vimahk commented 3 years ago

[https://github.com/gothinkster/spring-boot-realworld-example-app/blob/master/src/main/java/io/spring/core/article/Article.java] Article

core.article package in Articleclass constructor, you have collected Tags in the Set then immediately collected them into a List. Is there a good reason for that? If it's for shuffling, it's better to use Collections.shuffle().

Donquih0te commented 3 years ago

I think that did for removing duplicates