search

gothinkster / vue-realworld-example-app

An exemplary real-world application built with Vue.js, Vuex, axios and different other technologies. This is a good example to discover Vue for beginners.
https://vue-vuex-realworld.netlify.com
MIT License
4.07k stars 1.29k forks source link

VTag: Use computed property for router link #194

Open igeligel opened 5 years ago

igeligel commented 5 years ago 
<router-link
  :to="{ name: 'home-tag', params: { tag: name } }"
  :class="className"
>

Ideally, { name: 'home-tag', params: { tag: name } } should be a computed property and then used like:

<router-link
  :to="homeLink"
  :class="className"
>

Related resources:

kylerits commented 5 years ago

I can tackle this if you don't mind.

kylerits commented 5 years ago

PR at #224

andriyfm commented 5 years ago

Use computed property for router link #231

khuongphp commented 4 years ago

@andriyfm this PR got error that name is null We should accept pull request of @kylerits . That PR fix my error