gotify / server

A simple server for sending and receiving messages in real-time per WebSocket. (Includes a sleek web-ui)
https://gotify.net
Other
10.43k stars 593 forks source link

Wrong token copied after application rename #628

Closed disconn3ct closed 5 months ago

disconn3ct commented 5 months ago

Can the issue be reproduced with the latest available release? (y/n) y Which one is the environment gotify server is running in?

Do you have an reverse proxy installed in front of gotify server? (Please select None if the problem can be reproduced without the presense of a reverse proxy)

On which client do you experience problems? (Select as many as you can see)

What did you do? Rename an application (app1), then click the "copy token" on the same application without leaving the page.

What did you expect to see? Messages with that token are received on that application (app1).

What did you see instead? (Include screenshots, android logcat/request dumps if possible) The token was for a different app (app2). When opening the apps page again, the row holding app1 was now holding app2. It looks like the rename caused the tokens to be reordered without changing the visible names.

jmattheis commented 5 months ago

Cannot reproduce, could you give more detailed steps on how to reproduce this? repro.webm

disconn3ct commented 5 months ago

I tried a few times and could not get it to reproduce. It visually reorders them as soon as the new name is submitted and the tokens match the names.

I think there must have been something wedged that prevented the refresh. Maybe still a bug, but not a useful one :( Sorry for that.