gotify / server

A simple server for sending and receiving messages in real-time per WebSocket. (Includes a sleek web-ui)
https://gotify.net
Other
11.49k stars 639 forks source link

fix: panic when setting bool via envvar #734

Closed jmattheis closed 6 days ago

jmattheis commented 6 days ago

Don't know exactly what the problem is, but not having pointers for the booleans seem to help and they seem unnecessary.

$ docker run -e GOTIFY_SERVER_SSL_ENABLED=true --rm gotify/server:2.6.0
Starting Gotify version 2.6.0@2024-11-15-19:19:19
panic: reflect.Set: value of type bool is not assignable to type *bool

goroutine 1 [running]:
reflect.Value.assignTo({0xf5e000?, 0x1c375a8?, 0x19?}, {0x108809b, 0xb}, 0xf42960, 0x0)
        /usr/local/go/src/reflect/value.go:3358 +0x299
reflect.Value.Set({0xf42960?, 0xc0000cd200?, 0x4?}, {0xf5e000?, 0x1c375a8?, 0xf42960?})
        /usr/local/go/src/reflect/value.go:2313 +0xe6
github.com/jinzhu/configor.(*Configor).processTags(0xc0002f0270, {0xc0002eecc0?, 0xc0000cd200?}, {0xc0002ef0c0, 0x3, 0x4})
        /go/pkg/mod/github.com/jinzhu/configor@v1.2.2/utils.go:307 +0xc11
github.com/jinzhu/configor.(*Configor).processTags(0xc0002f0270, {0xc0002eec80?, 0xc0000cd1e0?}, {0xc0002ad880, 0x2, 0x2})
        /go/pkg/mod/github.com/jinzhu/configor@v1.2.2/utils.go:330 +0xe79
github.com/jinzhu/configor.(*Configor).processTags(0xc0002f0270, {0xf41420?, 0xc0000cd1e0?}, {0xc0002f0610, 0x1, 0x1})
        /go/pkg/mod/github.com/jinzhu/configor@v1.2.2/utils.go:330 +0xe79
github.com/jinzhu/configor.(*Configor).load(0xc0002f0270, {0xf41420, 0xc0000cd1e0}, 0x0, {0xc0002ad7a0?, 0x1c7c000?, 0xc0002ad7a0?})
        /go/pkg/mod/github.com/jinzhu/configor@v1.2.2/utils.go:415 +0x3f8
github.com/jinzhu/configor.(*Configor).Load(0xc0002f0270, {0xf41420, 0xc0000cd1e0}, {0xc0002ad7a0, 0x2, 0x2})
        /go/pkg/mod/github.com/jinzhu/configor@v1.2.2/configor.go:92 +0x13c
github.com/gotify/server/v2/config.Get()
        /src/gotify/config/config.go:69 +0xf3
main.main()
        /src/gotify/app.go:34 +0x1e5

See https://github.com/gotify/server/issues/731#issuecomment-2479974046

Is an upstream issue: https://github.com/jinzhu/configor/issues/92

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.42%. Comparing base (8639316) to head (6b3ff77). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
runner/runner.go 0.00% 3 Missing :warning:
router/router.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #734 +/- ## ======================================= Coverage 79.42% 79.42% ======================================= Files 56 56 Lines 2639 2639 ======================================= Hits 2096 2096 Misses 452 452 Partials 91 91 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.