search

gotjosh / INS353-2014-2

Repository with all the information regarding the Ruby on Rails - INS353 subject.
MIT License
0 stars 5 forks source link

Missing `Triangle#scalene?` method in `triangle_spec.rb` file. #3

Closed francisbrito closed 10 years ago

francisbrito commented 10 years ago

Would submit a PR myself, but am afraid my working copy is dirty.

eericart commented 10 years ago

i think is redundant a method for scalene because is not a one of the other is scalene

francisbrito commented 10 years ago

Although if a triangle is neither isosceles nor equilateral it is safe to say it's scalene, I would still vote for providing the method for the sake of completeness.

EDIT:

You're completely right @ernest21, simplicity beats completeness.

gotjosh commented 10 years ago

I totally agree with @ernest21, whatever you're returning should suffice to specify that the triangle is scalene. IE: 

def kind
  # implementation goes here
  else
    :escale
  end
end