bugfixes in tridiagonal and diffusion

[knutaros]

• avoid segfaults in tridiagonal() for one element [see new test_tridiagonal]
• avoid multiple divisions in tridiagonal
• avoid segfaults in diff_center() and diff_face() for one layer
• rewrite of diffusion routine: clearer code; less divisions; consider cell volumes and interface areas (required for e.g. porosity or gotm-lake)
• branch should be merged without squash to keep atomic commits

[bolding]

Hi Knut

Do you have Github Actions enabled? If so - I assume the changes passes?

And can you add test of test_tridiagonal to GA?

Karsten

[knutaros]

sorry, no clue about GA. I assume that I cannot check changes in my repo with the tests you set up for the official gotm repo?

On 7/8/22 07:48, Karsten Bolding wrote:

Hi Knut

Do you have Github Actions enabled? If so - I assume the changes passes?

And can you add test of test_tridiagonal to GA?

Karsten

— Reply to this email directly, view it on GitHub https://github.com/gotm-model/code/pull/34#issuecomment-1178580411, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2RV6TI6ULAPW7KYUWUTRTVS66MBANCNFSM525OKREA. You are receiving this because you authored the thread.Message ID: @.***>

[bolding]

The GOTM code has a folder called .github/workflows

in there is a file called gotm.yml - and in that you can do a whole lot of nifty things on the Github servers.

After the section " -name: Build and run all test cases" you can add a new section that will build and test tridiagonal.

Typical a few tries are needed :-) If you use Gitlab - I don't know - or the IOW repository.

[bolding]

https://github.com/gotm-model/code/runs/7094563994?check_suite_focus=true

[bolding]

Hi Knut

What is the status on this?

Karsten