search

gotm-model / code

Source code for the General Ocean Turbulence Model
https://gotm.net
GNU General Public License v2.0
53 stars 44 forks source link

Langmuir #52

Closed bolding closed 2 weeks ago

bolding commented 2 weeks ago

As we are waiting for Knut to get 2FA I'll create the PR on his behalf.

bolding commented 2 weeks ago

If merged in it will likely create issues with GA as YAML files for cases are not updated.

In addition - are there configurations available for testing the new code.

jornbr commented 2 weeks ago

Regarding GA - it looks like all the checks completed successfully already?

bolding commented 2 weeks ago

Yes - but entries are added to the YAML file. And if cases are not updated how can they read them - and use some of the new settings?

knutaros commented 2 weeks ago

I only added the new option quasi_eq_h15 to the existing entry scnd_method: https://github.com/gotm-model/code/pull/52/files#diff-c48e6470fdfda065545361404b8db40451c037e8559d552ffc59ae02c792a4e6R759

On 6/21/24 15:48, Karsten Bolding wrote:

Yes - but entries are added to the YAML file. And if cases are not updated how can they read them - and use some of the new settings?

— Reply to this email directly, view it on GitHub https://github.com/gotm-model/code/pull/52#issuecomment-2182792335, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2RV6UIKC5QRYNTYC3WGS3ZIQVLVAVCNFSM6AAAAABJV5HFESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSG44TEMZTGU. You are receiving this because you are subscribed to this thread.Message ID: @.***>

bolding commented 2 weeks ago

But none of the existing cases will use that setting! So the GA will not test the new code at all - or did I misunderstand something.