Open elsassph opened 8 months ago
thanks for the interest! I would be open to some PRs (robustness improvements like throwing early on cycles instead of stack overflowing would be great) but within these boundaries:
If those are not suitable for your case it's better to fork 🙂
@goto-bus-stop what are your thoughts on ES modules?
there's a huge amount of projects we could migrate to using this package, but ESM is a blocker for many of those.
~similarly, typescript definitions (i haven't checked if there's a @types
package).~ i'm blind, you already have them! 🤩
happy to do both of these tasks if you're up for taking them on. for esm, two entrypoints could work if you want to keep CJS compatibility.
as for things like comma-separated values, maybe its worth at least exposing some kind of transform function to let the consumer implement that themselves. you can keep what you have that way, other than an extra transform
param of some sort ((val: unknown) => string
).
For our use case, dates would be relevant. I'd like them to get serialized using .toISOString
.
Hello, the intentions are good (and basics work) but it doesn't handle cycles or have basic options like serializing arrays as comma-separated values.
Are you open to PRs and would you release updates in a timely manner?