goto-bus-stop / recanalyst

Analyzes Age of Empires 2 recorded game files.
https://goto-bus-stop.github.io/recanalyst/doc/v4.2.0
GNU General Public License v3.0
77 stars 11 forks source link

Test HD patch 4.8 #27

Closed goto-bus-stop closed 7 years ago

goto-bus-stop commented 7 years ago

Looking at the changes in the patch announcement post, it mentions there are dat file changes and changes in command structure.

So we might need to skip the command packet ID in here somewhere: https://github.com/goto-bus-stop/recanalyst/blob/master/src/Analyzers/BodyAnalyzer.php#L203-L208

And the data changes may require changes in the header analysis, but I'm not sure. We should add one or more HD 4.8 records in the test/recs/versions directory to check.

goto-bus-stop commented 7 years ago

Got a multiplayer 4.8 game from T-West. The internal version number is 12.49.

The current header-skipping code fails, because the 0xA3, 0x5F, 0x02, 0x00 sequence doesn't appear exactly 6 times in the aoe2record header (I'm not actually 100% sure if it always did in the first place, but it worked for the games I tested up until patch 4.7).

The 4.8 aoe2record header does contain the name of the multiplayer lobby, which IIRC wasn't there before, and that would be a useful thing to read as well.

Reading the game body seems fine.