Show Fish Spots in the Mini-Map

goto-bus-stop / recanalyst

Analyzes Age of Empires 2 recorded game files.

GNU General Public License v3.0

76 stars 10 forks source link

Open ritiek opened 7 years ago

ritiek commented 7 years ago

First of all thanks for this awesome API!

I was wondering if it is possible to show fishes when generating minimap screenshots? That would make the mini-map more complete.

goto-bus-stop commented 7 years ago

Good idea! I think this would need 3 things:

Adding constants for the fish unit IDs in src/ResourcePacks/AgeOfEmpires/Unit.php
Adding the fish unit IDs to the isGaiaUnit check in src/ResourcePacks/AgeOfEmpires.php
Adding colors for the fish unit IDs in src/ResourcePacks/AgeOfEmpires/Colors.php

Would you like to have a shot at a PR for this? I don't have a lot of time for RecAnalyst at the moment myself

ritiek commented 7 years ago

My PHP is very basic but i'll try to work on it, might learn a lot more. Will update you on how it goes.

goto-bus-stop commented 7 years ago

Great, thanks! Feel free to comment here or join the Gitter if you have questions