goto-bus-stop / recanalyst

Analyzes Age of Empires 2 recorded game files.
https://goto-bus-stop.github.io/recanalyst/doc/v4.2.0
GNU General Public License v3.0
77 stars 11 forks source link

Bug fix for chat message and version detection update #57

Closed lichifeng closed 6 years ago

lichifeng commented 6 years ago

Bug fix for chat message

Before a game actually begins, player come in and out. Image this: player A came to the room and leave some chat messages and left, then player B came and took A's position, both A and B will have same number, that makes your logic sometimes getting false chat information.

Two records below contain pregame chat messages from players who talks before game began but did not attend the game at last. I attached them here for your convenience, but they contains Chinese characters, you may find your own case for testing.

Record for test 1

Record for test 2

Version detection update

Until v4.2.1, records of AOC 1.0 and AOC 1.0c are both recogonized as AOC. I updated some code so that recanalyst can tell between two child versions of version AOC.

Two records below contain an AOC 1.0 version record and an AOC 1.0c one.

AOC 1.0 record

AOC 1.0c record

lichifeng commented 6 years ago

I was wrong.