search

goto-bus-stop / setup-zig

use a @ziglang compiler in your github actions workflows
Other
147 stars 19 forks source link

feat: update to use node20 #61

Closed chenrui333 closed 7 months ago

chenrui333 commented 8 months ago

This is consistent with all the recent github action updates. (mostly in actions repos, like actions/checkout, actions/setup-node, etc.)

Node12 was deleted from runner. Node20 was added to Actions Runner on v2.308.0. Node16 has en end of life on 11 Sep 2023.

This PR updates the default runtime to node20, rather then node16

relates to https://github.com/actions/runner/pull/2732

chenrui333 commented 8 months ago

cc @goto-bus-stop

chenrui333 commented 8 months ago

looks like there is some issue with testing against zig 0.11.0, https://github.com/chenrui333/setup-zig/actions/runs/7296724152/job/19884920370

goto-bus-stop commented 7 months ago

thanks for the PR! zig 0.11 changed the build system so i've pulled that out into https://github.com/goto-bus-stop/setup-zig/pull/62.

chenrui333 commented 7 months ago

@goto-bus-stop also the setup action should be bumped to v3 per this upgrade. :)

goto-bus-stop commented 7 months ago

imo it's OK to treat this bump as non-breaking since the environment it runs in is known to be compatible (aside from self-hosted runners, maybe?) and the cost of a major version bump on actions is very high as most projects do not have dependabot configured for actions.