search

gotoz / runq

run regular Docker images in KVM/Qemu
Apache License 2.0
802 stars 45 forks source link

Fix for Dockerfile smell DL3007 #23

Closed grosa1 closed 1 year ago

grosa1 commented 1 year ago

Hi! The Dockerfile placed at "test/examples/Dockerfile.dnsmasq" contains the best practice violation DL3007 detected by the hadolint tool.

The smell DL3007 occurs when the tag "latest" is used instead of a specific version tag for the base image. In this pull request, we propose a fix for that smell generated by our fixing tool. We have verified that the patch is correct before opening the pull request. To fix this smell, specifically, we use a heuristic approach that selects the most probable version tag for the base image in order to replace the "latest" tag. In detail, it selects the most recent image tag which corresponds to the same image digest that currently corresponds to the "latest" tag.

This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.

Thanks in advance

pmorjan commented 1 year ago

This PR makes no sense. And the source looks suspicious.