Bug Report: Admin User Receives 403 Error When Accessing Library

Kuan-Lun commented 4 months ago

Steps to reproduce

Utilize two libraries, named A and B.
Create a user account named alice who is not an administrator.
Modify the access restrictions for library A but not for library B.
Append authorization using the URL [komg-url]swagger-ui/index.html.
Change the user role of alice to an administrator.
Attempt to use the REST API to retrieve information from library B.
Observe a 403 Error, indicating forbidden access to library B despite alice now being an administrator. This error is unexpected as admin rights should grant full access.
Change the user role of alice back to a non-administrator.
Modify the access restrictions for both libraries A and B.
Change the user role of alice to an administrator.
Successfully access library B after the access restrictions modification.

Expected behavior

See step 7.

Actual behavior

See step 6.

Logs

No response

Komga version

v1.10.4-master

Operating system

Linux

Installation method

Docker

Other details

No response

Acknowledgements

[X] I have searched the existing issues (open AND closed) and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have checked the FAQ.
[X] I have updated the app to the latest version.
[X] I will fill out all of the requested information in this form.

gotson commented 4 months ago

I don't understand what you are doing tbh

Kuan-Lun commented 4 months ago

Granting any account administrator permissions should allow the account to access all libraries. However, in practice, the libraries accessible are limited to those set for access before the administrator permissions were granted. I think this might be a bug.

gotson commented 4 months ago

can you provide which endpoints you tried that returned that error ?

Kuan-Lun commented 4 months ago

import requests  # type: ignore
from requests.auth import HTTPBasicAuth  # type: ignore

url = f"[komga-url]/api/v1/books/0FR5EDTZ1XAKA/metadata"
response = requests.patch(
    url, auth=HTTPBasicAuth("test@example.com", "test123"), json={"title": "new title"}
)
response.raise_for_status()

requests.exceptions.HTTPError: 403 Client Error: for url: [komga-url]/api/v1/books/0FR5EDTZ1XAKA/metadata

github-actions[bot] commented 4 months ago

🎉 This issue has been resolved in 1.11.0 (Release Notes)

gotson / komga