gotson / komga

Media server for comics/mangas/BDs/magazines/eBooks with API, OPDS and Kobo Sync support
https://komga.org
MIT License
4k stars 237 forks source link

[Feature Request] Web reader: Don't notify about explicit reading direction if the same as the default #151

Closed mihailim closed 4 years ago

mihailim commented 4 years ago

Is your feature request related to a problem? Please describe.

For comics where an explicit reading direction is set (e.g. by inferring it from ComicInfo.xml via Manga: No), the web reader interface pops up the snackReadingDirection snackbar irrespective of whether the explicitly set reading direction is actually the same as the user's default reading direction preference. This is a bit annoying since it doesn't convey any useful information ("nothing was changed!") and has to be dismissed every time. The logic is implemented in BookReader.vue here.

Describe the solution you'd like

It would be useful to only pop up snackReadingDirection iff book.metadata.readingDirection differs from settings.readingDirection, i.e. something along these lines here:

      // bypass setter so cookies aren't set
      if (this.settings.readingDirection != this.book.metadata.readingDirection) {
        this.settings.readingDirection = this.book.metadata.readingDirection
        this.snackReadingDirection = true
      }

(Didn't send a PR since I'm not really familiar with Vue :smile: )

Thank you!

mihailim commented 4 years ago

Awesome, thank you so much! :)

gotson commented 4 years ago

:tada: This issue has been resolved in version 0.29.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

mihailim commented 4 years ago

Confirming explicitly that it works on this end.