Closed mihailim closed 4 years ago
Awesome, thank you so much! :)
:tada: This issue has been resolved in version 0.29.0 :tada:
The release is available on:
v0.29.0
Your semantic-release bot :package::rocket:
Confirming explicitly that it works on this end.
Is your feature request related to a problem? Please describe.
For comics where an explicit reading direction is set (e.g. by inferring it from ComicInfo.xml via Manga: No), the web reader interface pops up the snackReadingDirection snackbar irrespective of whether the explicitly set reading direction is actually the same as the user's default reading direction preference. This is a bit annoying since it doesn't convey any useful information ("nothing was changed!") and has to be dismissed every time. The logic is implemented in BookReader.vue here.
Describe the solution you'd like
It would be useful to only pop up snackReadingDirection iff
book.metadata.readingDirection
differs fromsettings.readingDirection
, i.e. something along these lines here:(Didn't send a PR since I'm not really familiar with Vue :smile: )
Thank you!