gotson / komga

Media server for comics/mangas/BDs/magazines/eBooks with API, OPDS and Kobo Sync support
https://komga.org
MIT License
4.02k stars 239 forks source link

[Feature Request] Publisher view in ODPS catalogue #332

Closed jt196 closed 4 years ago

jt196 commented 4 years ago

Is your feature request related to a problem? Please describe.

It's not possible to see publishers in the ODPS view

Describe the solution you'd like

A publisher view in the ODPS catalogue

Describe alternatives you've considered or other apps that can do what you want

n/a

Additional context

n/a

gotson commented 4 years ago

What kind of navigation do you expect in the opds feed?

Root > By publishers > list of all publishers > series?

gotson commented 4 years ago

It's not possible to see publishers in the ODPS view

This is very different from what you request. Seeing publishers would mean that from a series you could see its publishers.

Navigating by publisher is what you actually seem to request.

jt196 commented 4 years ago

Root > By publishers > list of all publishers > series?

Apologies if my request wasn't specific enough. This is what I meant.

I assumed as this is the way the filter by publisher in the web view works, this would be clear.

As the data is all there, it would be nice to browse through say all Marvel, DC, Image, Vertigo stuff in my collection on my mobile device.

gotson commented 4 years ago

:tada: This issue has been resolved in version 0.63.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jt196 commented 4 years ago

Great you got it in the latest release!

FYI @gotson this is broken on Chunky comic reader for iOS. I can enter the list of publishers, but if I enter into a publisher, the app crashes.

jt196 commented 4 years ago

The other new additions work btw.

gotson commented 4 years ago

Great you got it in the latest release!

FYI @gotson this is broken on Chunky comic reader for iOS. I can enter the list of publishers, but if I enter into a publisher, the app crashes.

I tried with Librera on Android and it works fine.

Try to get some logs and open a new issue.

gotson commented 4 years ago

Other users confirmed Chunky is working well for publishers, so it's probably just you!

jt196 commented 4 years ago

Gonna see if I can dig the logs out, and I'll make sure it's restarted/updated etc.

jt196 commented 4 years ago

@gotson it's still happening. Weirdly, not on every publisher, which may be why some of your colleagues are showing working configuration. Up to date Chunky running on an iPad with 13.5.1 iOS version on it.

Quick question, do you know what to do with IPS crash logs on iOS? I think you need XCode to view them as they're binary files. If you already have the capability to open them, I'll post them here, if not I'll need to figure out how to de-binary them/install Xcode.

Do you know if they contain sensitive data - if yes, I'll pm them if you don't mind.

If this is enough to figure it out, I'll leave it at posting the logs, if more debugging needs to be done, I'll start a new issue.

gotson commented 4 years ago

I have zero knowledge with iOS and its crash logs, you would have better luck with the chunky dev.

What you can do is send me the xml of the opds publisher section that make chunky crash, I can try to spot some weird characters or try to make it go through the opds validator.

Please open a new issue.

jt196 commented 4 years ago

@gotson where might I find that?

gotson commented 4 years ago

The opds feed can be navigated from any browser, just go to /opds/v1.2/publishers then find the publisher that's causing problem and follow that link. The browser will display the xml, which you can check for sensitive information and post either here or send to me directly via discord PM.

jt196 commented 4 years ago

OK figured it out - it's the publishers with spaces in the titles. Marvel works, Avatar Press doesn't.

Here's the entry:

<entry>
<title>Avatar Press</title>
<updated>2020-09-29T09:32:14.554965+01:00</updated>
<id>publisher:Avatar Press</id>
<content/>
<link type="application/atom+xml;profile=opds-catalog;kind=navigation" rel="subsection" href="/opds/v1.2/series?publisher=Avatar Press"/>
</entry> 
jt196 commented 4 years ago

OK opened this up as issue 335.