gottagetit / phoshare

Automatically exported from code.google.com/p/phoshare
Other
0 stars 0 forks source link

IPhotoData.check_photos and IPhotoContainer.__init__ depend on name 'Photos' to determine master album #40

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?

1. with a non-english AlbumData.xml file, run the following script (attached as 
show_Photos_issue.py):

###
import appledata.iphotodata as ID

i = ID.get_iphoto_data('AlbumData.xml', verbose=True)

for album in i.albums.values():
    if album.master:
        print "album type of master album: %s" % album.albumtype

i.check_photos()
###

(tested with a german iPhoto 8.1.2 AlbumData.xml file)

What is the expected output? What do you see instead?

- expected:

$ python show_Photos_issue.py
Reading iPhoto database from ...
album type of master album: Master

- actual output

$ python show_Photos_issue.py
Reading iPhoto database from ...
No album type for Fotos.
album type of master album: None
No Photos album in library.

What version of the product are you using? On what operating system?

Phoshare 1.4.7 (currently testing only the AlbumData.xml parsing on Linux)

Please provide any additional information below.

- patch file that should IMHO fix this is attached
- I can supply an AlbumData.xml file to demonstrate on request, but would have 
to prepare one not including any of my personal information first.

Original issue reported on code.google.com by manuel.r...@gmail.com on 20 Sep 2012 at 11:11

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for the patch, I'll check it out and merge it into the next update.

Original comment by tsporkert on 20 Sep 2012 at 5:10

GoogleCodeExporter commented 8 years ago
Ah, now I see what is going on here. "Photos" got changed to "Fotos". That's 
odd, because there are many Phoshare users with non-english setups, and this is 
the first time I hear about this issue.

Original comment by tsporkert on 1 Oct 2012 at 2:03

GoogleCodeExporter commented 8 years ago
Incorporated into Phoshare 1.5.1

Original comment by tsporkert on 3 Oct 2012 at 7:20