search

gottfrois / dashing-rails

The exceptionally handsome dashboard framework for Rails.
MIT License
1.45k stars 149 forks source link

Use connection pool without wrapper #103

Closed translatorzepp closed 6 years ago

translatorzepp commented 6 years ago

Per the connection_pool documentation, using ConnectionPool::Wrapper is not performant and has been replaced by with on a connection pool to obtain a connection. This PR is a rough-and-ready switch over to using the new ConnectionPool.new instead of the old, temporary ConnectionPool::Wrapper.new.

This may address some issues where redis connections are not being released: https://github.com/gottfrois/dashing-rails/issues/94, https://github.com/gottfrois/dashing-rails/issues/60.

Followed https://github.com/mperham/connection_pool#migrating-to-a-connection-pool to make the changes.

gottfrois commented 6 years ago

Looks great! Thx for the PW

translatorzepp commented 6 years ago

@gottfrois any chance of a new release with this sometime soon?

gottfrois commented 6 years ago

sure thing v2.6.2