search

gotthardp / rabbitmq-email

SMTP Gateway Plugin for RabbitMQ
Mozilla Public License 2.0
180 stars 20 forks source link

Introduce config option for setting concurrent sessions limit #41

Closed listerenko closed 4 years ago

listerenko commented 4 years ago

Hi!

We use this plugin to handle email bounces and unsubscribe requests and have encountered a problem wtih too restrictive session limit. As a quick hack we tested 20000 in our fork and it seemed to work fine under production load.

I tried to move this parameter to config file so you would accept it to upstream (and it looks like something that would work), but Erlang is a bit too much for me to grasp at once and travis-ci somehow fails to build even clean master from my account, so I would welcome any directions you can provide for me to ensure this fix would behave as expected.

listerenko commented 4 years ago

@lukebakken Hi! Sorry to bother you, but is there any chance you would be willing to take a look?

lukebakken commented 4 years ago

Please be patient. This plugin is maintained by volunteers who do so in their free time.

lukebakken commented 4 years ago

@listerenko I realize it has been a long time since you opened this pull request. I will see if I can find time to review by the end of the month. The RabbitMQ team maintains this plugin and we've been busy.

listerenko commented 4 years ago

Oh, there's no need to. I understand it was not a priority, it's okay. We have found another solution and stopped using this plugin, so even if my code works fine (that would be a surprise :-) ), we no longer require it and will not be able to test it in production.

lukebakken commented 4 years ago

OK! I appreciate the explanation!