search

gotthardp / rabbitmq-email

SMTP Gateway Plugin for RabbitMQ
Mozilla Public License 2.0
180 stars 20 forks source link

Make this plugin compatible with RabbitMQ 3.9.x #46

Closed lukebakken closed 2 years ago

lukebakken commented 3 years ago

Fixes #45

Start with the following:

mforde84 commented 2 years ago

Ok let me see if I compile. Ill update more when I have additional information on iconv. Thankyou again btw.

lukebakken commented 2 years ago

@lhoguin @essen @michaelklishin I have a question about setting the RabbitMQ version in the Makefile -

https://github.com/gotthardp/rabbitmq-email/blob/update-for-rmq/Makefile#L8-L12

If a RabbitMQ user is using version 3.9.9, I would like this to be the command to build this plugin using the v3.9.9 RabbitMQ code:

make RABBITMQ_VERSION=v3.9.9

but, when I run the above, the cloned rabbitmq-server repo is at master:

lbakken@shostakovich ~/development/gotthardp/rabbitmq-email (update-for-rmq $=)
$ cd .erlang.mk/rabbitmq-server/
lbakken@shostakovich ~/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server (master=)
$ git branch
* master

In this PR I have the same version of erlang.mk and rabbitmq-components.mk from the v3.9.x branch of rabbitmq/rabbitmq-server.

essen commented 2 years ago

@lukebakken See comment. It will pick the version from the command-line if one was set, otherwise use the v3.9.x as default.

essen commented 2 years ago

There's probably another issue, checking...

lukebakken commented 2 years ago

@essen many thanks.