gottsch / gottsch-minecraft-Treasure

Source code for gottsch's Treasure2! minecraft mod.
https://www.curseforge.com/minecraft/mc-mods/treasure2
16 stars 12 forks source link

Internal Server Hang and Crash. [1.12.2] #313

Closed Handeril closed 8 months ago

Handeril commented 1 year ago

This is a VERY technical bug that has been an ongoing issue in my in-development modpack. [Possibly years]

Basically while loading chunks in the world sometimes, the game will stop loading chunks altogether, and the internal server will hang - which forces people to crash to desktop.

This behavior is most notable in "Skyblock" and Superflat Worlds, but also occurs in normal worlds on rare occasions.

This is a thread dump of my hung Minecraft Instance: mc_threaddump4.txt

The problem thread can be found at "Server thread" #763 prio=5 os_prio=0 tid=0x000000007b0a0000 nid=0x3b300 runnable [0x000000004cc8d000]

Hopefully this can be fixed somehow.

[This problem does not produce a proper crash report.]

ACGaming commented 1 year ago

Precisely, the hang occurs here: https://github.com/gottsch/gottsch-minecraft-GottschCore/blob/1.12.2-master/src/main/java/com/someguyssoftware/gottschcore/world/gen/structure/DecayProcessor.java#L114-L115 Maybe replace the while loop with a for loop and a limited number of tries?

Handeril commented 11 months ago

I am pretty excited to possibly see an update on this particular crash.

gottsch commented 8 months ago

This should be fixed in v1.15.1

Handeril commented 8 months ago

Thank you for addressing this, and for your time.