search

gottyduke / SF_PluginTemplate

Plugin template for SFSE plugins. click "Use this template" to generate your project.
GNU General Public License v3.0
38 stars 9 forks source link

Nether UsesAddressLibrary nor UsesSigScanning should be default true in the template #5

Closed igromanru closed 10 months ago

igromanru commented 10 months ago

I have noticed that many SFSE plugin authors use this template as is.
They don't even know what a sig scan or the address library is and don't pay attention to the PluginVersionData. They just let it as it is to "true" with hard coded offset to a static address.
I know that currently the addressIndependence check is not implemented in SFSE, but the idea of it, that SFSE will not refuse to load mods that have it set to true, even if the game version mismatch with one of compatibleVersions.
Therefore I think both UsesAddressLibrary and UsesSigScanning should be commented out per default, so the author must make a conscious decision to set the right flag to true.

igromanru commented 10 months ago

Thanks