search

gotwarlost / istanbul-middleware

Connect middleware for server side code coverage using istanbul
Other
179 stars 96 forks source link

Announce: istanbul-middleware #1

Closed gotwarlost closed 10 years ago

gotwarlost commented 11 years ago

/ping @ariya @davglass @xolvio @reid @mfncooper @proverma

check this out and let me know what you think.

Cheers, Krishnan

P.S: I've been using this for a while in an internal project just fine. However, I suddenly saw event-emitter-leak warnings in the Travis build - go figure :) I will look into this a bit later.

xolvio commented 11 years ago

Fantastic news! I'll get you feedback as soon as I can. I'll be attempting it on Meteor.

gotwarlost commented 11 years ago

@xolvio - that's probably a pretty complex use-case. Start with something simpler :)

reid commented 11 years ago

Nice work, @gotwarlost! :thumbsup:

ariya commented 11 years ago

Looks great!

davglass commented 11 years ago

Love it! :thumbsup:

xolvio commented 11 years ago

Through some hacking, shimming and wedging, I've got this working with Meteor. All I can say is thank you, thank you, thank you :+1:

You can see it here if you're interested. https://github.com/xolvio/rtd/tree/master/lib/istanbul-middleware-port

It's not pretty, but it works. The challenge was in two things:

1) Shimming express to use a meteor router package instead 2) Using Meteor's way of variable scoping (var = private, no var = global)

gotwarlost commented 11 years ago

@xolvio - cool!

arboleya commented 11 years ago

Awesome project, I must to say.

For those who fall here, know it: afaik, its the ONLY option available so far to get coverage for functional/acceptance tests under selenium!

This kick ass!

Congratulations